The CDB tests were attemptying to write in harcoded filename
/tmp/php.cdb and /tmp/dba.cdb. Whenever two jobs were running the same
test, we would end up with a mysteriously failling test. The test now
use random temporary file names.
Change-Id: Ia1e58f0c02418e6d01d6730f97b2103ed87eb4f4
$this->markTestSkipped( "Temp dir isn't writable" );
}
$this->markTestSkipped( "Temp dir isn't writable" );
}
- $w1 = new CdbWriter_PHP( "$dir/php.cdb" );
- $w2 = new CdbWriter_DBA( "$dir/dba.cdb" );
+ $phpcdbfile = $this->getNewTempFile();
+ $dbacdbfile = $this->getNewTempFile();
+
+ $w1 = new CdbWriter_PHP( $phpcdbfile );
+ $w2 = new CdbWriter_DBA( $dbacdbfile );
$data = array();
for ( $i = 0; $i < 1000; $i++ ) {
$data = array();
for ( $i = 0; $i < 1000; $i++ ) {
$w2->close();
$this->assertEquals(
$w2->close();
$this->assertEquals(
- md5_file( "$dir/dba.cdb" ),
- md5_file( "$dir/php.cdb" ),
+ md5_file( $phpcdbfile ),
+ md5_file( $dbacdbfile ),
- $r1 = new CdbReader_PHP( "$dir/php.cdb" );
- $r2 = new CdbReader_DBA( "$dir/dba.cdb" );
+ $r1 = new CdbReader_PHP( $phpcdbfile );
+ $r2 = new CdbReader_DBA( $dbacdbfile );
foreach ( $data as $key => $value ) {
if ( $key === '' ) {
foreach ( $data as $key => $value ) {
if ( $key === '' ) {
$this->cdbAssert( "DBA error", $key, $v2, $value );
}
$this->cdbAssert( "DBA error", $key, $v2, $value );
}
- unlink( "$dir/dba.cdb" );
- unlink( "$dir/php.cdb" );
}
private function randomString() {
}
private function randomString() {